Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023_R2 backports #2664

Merged
merged 2 commits into from
Dec 23, 2024
Merged

2023_R2 backports #2664

merged 2 commits into from
Dec 23, 2024

Conversation

nunojsa
Copy link
Collaborator

@nunojsa nunojsa commented Dec 4, 2024

PR Description

Two fixes for adrv9002 and ad7768 backported from main.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly (if there is the case)

@nunojsa
Copy link
Collaborator Author

nunojsa commented Dec 5, 2024

v2:

  • Fix the fact that devm_regulator_get_enable_read_voltage() is not available.

ad7768_scale() is dependent on the st->vref voltage. Hence, simplify the
code and get the voltage only during probe (as it should not change at
runtime) with devm_regulator_get_enable_read_voltage()

[nsa: devm_regulator_get_enable_read_voltage() is not available in
2023_R2, so do it by hand to get the voltage during probe]

Fixes: 92cc452 ("iio: adc: ad7768: simplify probe")
Co-developed-by: Dragos Bogdan <[email protected]>
Signed-off-by: Dragos Bogdan <[email protected]>
Signed-off-by: Nuno Sa <[email protected]>
(cherry picked from commit 44e7ac1)
Similar to

commit 7ebe866 ("iio: adc: adrv9002: fixup tx2 power level")

we need to apply the same fixup even in rx2tx2. The reasoning for not
doing it at the time was that if the channels are tuned together and
have the same SSI delays, it should not be needed. Well...

While at it (and as advised by HW folks), we're now doing the fixup for
all TX channels.

Signed-off-by: Nuno Sa <[email protected]>
(cherry picked from commit 13a58d5)
@nunojsa
Copy link
Collaborator Author

nunojsa commented Dec 5, 2024

Alright, the Fixes hash does not exist in the 2023_R2 branch as the original faulty commit was also cherry-picked in to the release branch. As this is yet another cherry-pick, I don't think it's that important to change the fixes tag so I would say to ignore the CI failure.

@nunojsa nunojsa merged commit 3a7e0d1 into 2023_R2 Dec 23, 2024
11 of 13 checks passed
@nunojsa nunojsa deleted the staging/2023_R2-backports branch December 23, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants